Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds zipkin.internal.Span2 #1669

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Adds zipkin.internal.Span2 #1669

merged 1 commit into from
Jul 28, 2017

Conversation

codefromthecrypt
Copy link
Member

@codefromthecrypt codefromthecrypt commented Jul 27, 2017 •
edited
Loading

This adds an internal copy of the new span data structure defined in
issue #1499. This is starting internal to ease review and allow
incremental progress. The first consumer will be dependency linking.

Benchmarks:

Benchmark                                   Mode  Cnt   Score   Error   Units
SpanBenchmarks.buildClientOnlySpan         thrpt   15   3.810 ± 0.216  ops/us
SpanBenchmarks.buildClientOnlySpan_clear   thrpt   15   4.087 ± 0.194  ops/us
SpanBenchmarks.buildClientOnlySpan2        thrpt   15   6.683 ± 0.259  ops/us
SpanBenchmarks.buildClientOnlySpan2_clear  thrpt   15   6.865 ± 0.508  ops/us
SpanBenchmarks.buildClientOnlySpan2_clone  thrpt   15   7.320 ± 0.247  ops/us

This was referenced Jul 27, 2017
Closed
Closed
Closed
@codefromthecrypt
Copy link
Member Author

#1670 follows this

Adds zipkin.internal.Span2
a9e991a 
This adds an internal copy of the new span data structure defined in
issue 1499. This is starting internal to ease review and allow
incremental progress. The first consumer will be dependency linking.
@codefromthecrypt codefromthecrypt merged commit dbdda44 into master Jul 28, 2017
@codefromthecrypt codefromthecrypt deleted the span2 branch July 28, 2017 02:22
abesto pushed a commit to abesto/zipkin that referenced this pull request Sep 10, 2019
@adriancole @abesto
Adds zipkin.internal.Span2 (openzipkin#1669)
7bb85db 
This adds an internal copy of the new span data structure defined in
issue 1499. This is starting internal to ease review and allow
incremental progress. The first consumer will be dependency linking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codefromthecrypt